-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devcontainer #493
base: main
Are you sure you want to change the base?
Add devcontainer #493
Conversation
Wow! This is great work. This was attempted in #491 but looks like that PR was closed. Could you add something to the readme that states the dev container only works on Linux? I spun it up on my Mac and ran into issues with USB forwarding, and would also probably run into problems with display output from GTK. Could you also move the |
Sorted!
That is quite, interesting. I myself run it on a Windows 11 host with Docker Desktop and WSL2 Ubuntu backend.
Oh neat! Didn't see that one. |
Ah, great to hear it works with WSL. Probably just needs some tweaking for MacOS/Linux, but that shouldn't hold up this PR! Could still use a note in the README here about it only working in Windows, just so new devs don't get the wrong idea and get frustrated if things don't work as expected. |
I have somewhere in the back of my head that playing with the Also added a note at the top of the README, hopefully that can get updated as more devs give it a go 👍 |
Yeah WSL is pretty well-instrumented from my experience. Looks like this thread has some similar issues to mine, so maybe related to some MacOS docker stuff being more locked down?
This note is perfect, thanks. |
Updated to match meshtastic/firmware#4278, give it a go |
Still no dice. I'm getting the same SPI issue when trying to run the standalone meshtasticd container, so this may need some more involvement to debug. In the meantime I'm spinning this up on an old Ubuntu machine to see if that works. Container build took about 40 minutes, and had to retry a few times to get the VSCode Server to install in the container. |
I ran the following on the Ubuntu host:
This lets the display output through, but the initial container script fails. On finishing, I was able to run |
I have just tested today on Fedora/Nobara 41 worked as it was meant to be, great work. I used a remote web connection to my node this time. |
Hey @matthewCmatt , if you do find a moment. Adjust line 1 in .devcontainer/Dockerfile from |
Thanks for looking into this! I was able to get the devcontainer working fine by installing XQuartz for the display forwarding. This worked on Apple ARM fine without having to change the Debian version. I had to resize the window manually to get the virtual display to fill the whole window, but otherwise works well! |
Here's the guide I used to get it working https://gist.github.com/sorny/969fe55d85c9b0035b0109a31cbcb088 |
Added an initial development container configuration.
Tested on a Windows11 host, Docker Desktop, and a WSL2 Ubuntu installation.
It starts up, installs dependencies needed to run
pnpm run rust:dev
.Also installs
meshtasticd
andmeshtastic CLI
.With that it's possible to access the application, see a node.
I did try changing some text in the application and it works.
issue #471
issue #472