PowerMon initial protobufs #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh I see how the linter is complaining. I'll fix. |
thebentern
approved these changes
Jun 21, 2024
andrekir
reviewed
Jun 30, 2024
| * If non-zero, we want powermon log outputs. With the particular (bitfield) sources enabled. | ||
| * Note: we picked an ID of 32 so that lower more efficient IDs can be used for more frequently used options. | ||
| */ | ||
| uint64 powermon_enables = 32; |
There was a problem hiding this comment.
@geeksville does powermon need uint64? our other bitwise fields are using uint32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be a nop for anyone else (for the time being). But checking in now (seems pretty stable - probably no big changes coming) so I can soonish propose firmware and python PRs that use this.
for meshtastic/firmware#4136