Skip to content

Conversation

thebentern
Copy link
Contributor

No description provided.

@andrekir
Copy link
Member

andrekir commented Aug 8, 2024

by the size of the message field I believe remote admin/configuration is not included?

we could send the invalid config "error" codes/enums and tie them to pre-defined strings (using protos as source) on the client side, similar to Routing errors or simply expand the routing errors to include config errors.

clients should also be able to catch the "invalid config" within the config logic. currently the Android app waits for the Routing error to consider the config change successful or not.

@thebentern
Copy link
Contributor Author

thebentern commented Aug 8, 2024

by the size of the message field I believe remote admin/configuration is not included?

Correct. The idea is that we need a general window into knowing things that only the device knows currently. This would extend to beyond config feedback mechanisms though. For instance another use that I have in mind is the event / festival case where we can push up a notification when the channel utilization spikes to unusable rates suggesting the user switch to a higher bandwidth preset.

@thebentern
Copy link
Contributor Author

Also duty cycle warnings is another one I had in mind.

@garthvh
Copy link
Member

garthvh commented Aug 8, 2024

So even more general purpose? A client would just display these in a dialog when received?

@thebentern
Copy link
Contributor Author

So even more general purpose? A client would just display these in a dialog when received?

Basically, yes. Field level validation feedback may not be the level of detail we address with these messages, but we could add a reply_id to a message that precipitated a warning or error response potentially.

Copy link
Member

@garthvh garthvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems useful

@thebentern thebentern merged commit c112ce6 into 2.5 Aug 8, 2024
@thebentern thebentern deleted the client-notification branch August 8, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants