Skip to content

Conversation

janveeh
Copy link

@janveeh janveeh commented Jun 11, 2025

Add New Device Embedded Arts Roamer to Hardware Model list

What does this PR do?

Adding an entry in the HardwareModel enum for new device

Related Issue

Checklist before merging

  • All top level messages commented
  • All enum members have unique descriptions

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jan Veeh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jp-bennett
Copy link
Contributor

Hey @janveeh, I don't anticipate this PR being a problem. Can you drop an email to contact (at) meshtastic.com with more information about the Roamer? Thanks!

@fifieldt
Copy link
Member

@janveeh , looks like the CLA remains unsigned?

@janveeh
Copy link
Author

janveeh commented Jun 25, 2025

Wierd.. I signed it directly after initiating the PR, I signed it once again now

@fifieldt
Copy link
Member

Might be that you have multiple emails

@janveeh
Copy link
Author

janveeh commented Jun 25, 2025

I deleted my backup E-Mail address from github. CLA remains as signed already
image

@thebentern thebentern marked this pull request as draft June 27, 2025 00:37
@janveeh janveeh marked this pull request as ready for review July 7, 2025 12:09
@janveeh
Copy link
Author

janveeh commented Sep 3, 2025

Is there any plan if / when this will be merged?

@Kongduino
Copy link

See this update. Community-supported devices are not eligible for their own Hardware ID. Plus, the proposed ID is already assigned.

@janveeh janveeh closed this Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants