Skip to content

Conversation

thebentern
Copy link
Contributor

No description provided.

@thebentern thebentern requested a review from Copilot June 15, 2025 11:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new boolean flag to the SharedContact message so that contacts can be marked as blocked (ignored).

  • Adds should_ignore field to SharedContact in the admin.proto definition
  • Includes a comment describing the new field
Comments suppressed due to low confidence (3)

meshtastic/admin.proto:529

  • [nitpick] The field name should_ignore is a bit verbose and mixes imperative tone; consider renaming to is_ignored or ignored for clearer boolean semantics.
bool should_ignore = 3;

meshtastic/admin.proto:526

  • The comment could be more precise: describe expected behavior when should_ignore is true (e.g., “When true, this contact is added to the ignored list and will not appear in the UI or sync operations.”).
/*

meshtastic/admin.proto:529

  • No tests appear to cover the new should_ignore flag; consider adding unit tests to verify serialization, default behavior (false), and handling in server-side logic.
bool should_ignore = 3;

@thebentern thebentern merged commit c758376 into master Jun 15, 2025
2 checks passed
@thebentern thebentern deleted the add_contact_ignore branch June 15, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant