SEN5X sensor definition #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscgonfer
force-pushed
the
feat/add-sen5x
branch
from
8f462ac to
ecfb8b8
Compare
|
I added new definitions for the SEN5X sensor here. My OCD tells me that PM4.0 should go in order, but I refrained from doing that... This keeps I am tempted to discuss this a bit further though. Its good to have the float there as the sensor provides the accuracy, but it'd require homogeneity across different sensors. If we then want to save space in the payload, this and other sensors would require scaling. |
caveman99
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new sensor definition for the SEN5X series.
Shouldn't merge yet, as it adds it naively and I am not sure we should use SEN5X, or SEN50, SEN54 and SEN55 separately.