Skip to content

Conversation

NillRudd
Copy link

@NillRudd NillRudd commented Oct 5, 2025

Fixes #833

Summary

  • Accept node IDs in decimal, !hex, and 0xhex; normalize to int.
  • Deduplicate lora.ignore_incoming on write.
  • Support clearing via config.lora.ignore_incoming: [] reliably.
  • Prevent crash: 'bytes' object cannot be interpreted as an integer.
  • Removed some duplicate code.

Why

CLI operations around ignore list were brittle:

  • Occasional crash when adding IDs.
  • Duplicate entries possible.
  • Inconsistent ID formats accepted.
  • Clearing via YAML sometimes confusing.

Behavior

  • --set lora.ignore_incoming <id> accepts dec/!hex/0xhex and stores one normalized entry.
  • --get lora.ignore_incoming reflects deduped list.
  • YAML config.lora.ignore_incoming: [] clears list.

Notes

Firmware still shows packets in logs; enforcement is firmware-level and out of scope here.
No breaking changes—CLI becomes more permissive and robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: lora.ignore_incoming crash (bytes→int), duplicates, and ID format inconsistency

1 participant