Feature/pass recipe to docker #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
Base automatically changed from
feature/aws-cli-in-docker
to
staging/cellpack-server
August 22, 2024 18:24
ascibisz
force-pushed
the
feature/pass-recipe-to-docker
branch
from
9d74276
to
3480a55
Compare
rugeli
approved these changes
Sep 20, 2024
mogres
approved these changes
Sep 20, 2024
cellpack/autopack/__init__.py
Outdated
| @@ -392,13 +392,13 @@ def read_text_file(filename, destination="", cache="collisionTrees", force=None) | |||
| return sphere_data | |||
|
|
|||
|
|
|||
| def load_file(filename, destination="", cache="geometries", force=None): | |||
| def load_file(filename, destination="", cache="geometries", force=None, use_docker=False): | |||
There was a problem hiding this comment.
Could we make this argument name more generic? Seeing as this flag decides the database to use, maybe it could be renamed to skip_database_check or something equivalent?
* retrieve job id * formatting * add a bucket for batch jobs * formatting * remove print statement and add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cleaning up docker code so we are actually passing the recipe / config parameters specified in the commandline / as ENV variables into the docker container.
Link to story or ticket
Solution
packscriptdockerfor when we want to default to pointing to staging for firebase without prompting the user via commandline. To use, we can call thepackscript from the commandline with the-dflag, i.e.pack -r my_recipe.json -c my_config.json -dType of change