add batch_job_id to result metadata
#295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
rugeli
commented
Oct 28, 2024
ascibisz
reviewed
Nov 1, 2024
| @@ -1398,23 +1398,35 @@ def raycast_test(self, obj, start, end, length, **kw): | |||
| def post_and_open_file(self, file_name, open_results_in_browser=True): | |||
| simularium_file = Path(f"{file_name}.simularium") | |||
| url = None | |||
| job_id = os.environ.get("AWS_BATCH_JOB_ID", None) | |||
| if job_id: | |||
| print(f"Batch Job ID: {job_id}") | |||
There was a problem hiding this comment.
nit: we can probably remove lines 1402 and 1403, this was just for debugging
meganrm
approved these changes
Nov 5, 2024
rugeli
added a commit
that referenced
this pull request
Nov 15, 2024
* draft aws cli inside of docker container * access aws s3 with saved cred * update readme * update docker commands * update readme * update readme * add parameter for when we're using docker to default to using the staging firebase db * read recipe and config in from docker run params * use dockerignore file to prevent bloat in docker image * add `batch_job_id` to result metadata (#295) * retrieve job id * formatting * add a bucket for batch jobs * formatting * remove print statement and add comments --------- Co-authored-by: Ruge Li <[email protected]> Co-authored-by: Ruge Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is the problem this work solves, including
closes #296
Solution
What I/we did to solve this problem
osbatch_job_idfield to result metadata, which will be uploaded to firebase upon successful packing. If the packing is local, the value will benullwith @ascibisz
Type of change
Please delete options that are not relevant.
Steps to Verify:
resultscollection in staging firebase database - recipe metadata should display the correct batch job idbatch_job_idfield should also be present but with anullvalueScreenshots (optional):
Show-n-tell images/animations here
Step 1 (API Gateway): use API gateway to trigger a packing batch job
Step 2 (AWS Batch): wait for the batch job to run
Step 3 (Firebase): batch job id will be added to the metadata and uploaded to firebase
