Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade firebase to v9.0 and vue3 #376

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

adrianjost
Copy link
Collaborator

@adrianjost adrianjost commented Feb 8, 2022

πŸ’¬ About

I've updated the dependencies of one of my hobby projects to use Vue3 and the latest firebase SDK (v9, not in compat mode).
To keep it running, I patched this package until it worked for my specific use case. I have not updated any test cases nor am I sure I've covered all cases. But in my limited use case everything worked as expected.

Maybe this can be a starting point for someone else to update this library to the latest dependency versions. Unfortunately, I don't have time for that.

πŸ” What has changed?

  • replaced Vue's reactive helpers with plain JS. Vue 3 can now handle these itself
  • replaced the firebase 8 syntax with the new explicit firebase 9 function calls.

πŸ’₯ Breaking Changes

🚫 What's missing

  • βœ… documentation needs to be updated. The Vue.use(Vuex) example is definitely outdated
  • βœ… Tests need to be checked and eventually fixed.
  • βœ… Maybe I missed some firestore legacy code. But the compiler didn't complain, so maybe it's complete. πŸ€·β€β™‚οΈ

πŸ‘¨β€πŸ’» How can I use that?

Currently, you could use:
npm i --save vuex-easy-firestore@github:adrianjost/vuex-easy-firestore#sdk-9
to test the patch from this PR in your repo. But I don't recommend doing this except for testing compatibility and adding further fixes.

@adrianjost
Copy link
Collaborator Author

@adrianjost
Copy link
Collaborator Author

A little update: I got all tests working βœ…

@adrianjost
Copy link
Collaborator Author

And now I even got some time to update the docs as well. πŸŽ‰

@adrianjost adrianjost marked this pull request as ready for review February 9, 2022 19:49
@mesqueeb
Copy link
Owner

@adrianjost really amazing job! let's get this released. I contacted you via your website.

@adrianjost
Copy link
Collaborator Author

Feel free to merge and release this whenever you want. From my side the code should be ready for it.

I'm just not 100% sure, if it should be released as 2.0.0 (because the new dependency versions are incompatible with the old ones) or it's okay the way it is. Semver isn't that clear to me in this case: https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api

@dassmilytier
Copy link

would love to see this feature finally merged. I was super happy to find this library as this is exactly what I was planning to implement for my project. Unfortunately I got emidiate disappointment when the library failed to load due to broken imports. Please continue your great work and merge this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants