Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#patch); baseswap; fix pool tvl, fees #2365

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dhruv-chauhan
Copy link
Collaborator

@dhruv-chauhan dhruv-chauhan commented Sep 11, 2023

  1. TVL mismatch
  • For WETH/BSWAP, there was an initial liquidity lock up of $410k in the WETH/BSWAP pool as BSWAP token's initial liquidity (docs, transaction), which is not counted in pool's liquidity on protocol's UI.
    However, we feel it should be counted as a regular transfer contributing to pool's liquidity, and will cause mispricing of LP token if not counted.
    Hence the subgraph will show WETH/BSWAP pool's liquidity greater than the protocol UI by $410k.
  • For DAI+/USD+, DAI+ token was not whitelisted; added.
  1. Revenues
  • Protocol incurs a total swap fee of 0.25% - 0.17% to supply side, 0.08% to treasury. Updated.

Deployment: https://okgraph.xyz/?q=dhruv-chauhan%2Fbaseswap-base

@melotik melotik requested a review from steegecs September 15, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant