Skip to content

Commit

Permalink
Run dep check in travis-ci
Browse files Browse the repository at this point in the history
This is from a discussion on ligato#327

Similar to the vpp-agent [1] [2], run `dep check` in travis-ci with each
commit and fail if someone adds vendored code without proper vendoring.

[1] https://github.com/ligato/vpp-agent/blob/pantheon-dev/.travis.yml#L41
[2] https://github.com/ligato/vpp-agent/blob/pantheon-dev/Makefile#L179-L181

Signed-off-by: Kyle Mestery <[email protected]>
  • Loading branch information
mestery committed Aug 21, 2018
1 parent 6557888 commit 171a480
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ before_install:
script:
- make check-links || true
- make lint
- make dep-check
- make
- make test-cover
# - make test-examples # TODO: refactor tests to not check exact log output
Expand Down
5 changes: 5 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,11 @@ dep-install: get-dep
dep-update: get-dep
dep ensure -update

# Check state of dependencies
dep-check: get-dep
@echo "=> checking dependencies"
dep check

LINTER := $(shell command -v gometalinter 2> /dev/null)

# Get linter tools
Expand Down

1 comment on commit 171a480

@ondrej-fabry
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are at it already please update make targe get-dep as well just like in vpp-agent: https://github.com/ligato/vpp-agent/blob/pantheon-dev/Makefile#L164-L166

This downloads latest stable release instead of installing from master.

Please sign in to comment.