Metric Logging updates 6/N - Enable SFT metrics / delete old file #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
October 8, 2025 08:38
…estamp_logging_diff2
…estamp_logging_diff3
…estamp_logging_diff3
…estamp_logging_diff3
meta-cla
bot
added
the
CLA Signed
added 2 commits
October 13, 2025 18:16
felipemello1
commented
Oct 22, 2025
There was a problem hiding this comment.
moved from forge/data/dataset_metrics
added 4 commits
October 21, 2025 17:40
added 2 commits
October 21, 2025 20:28
ebsmothers
approved these changes
Oct 22, 2025
photomz
pushed a commit
to photomz/forge
that referenced
this pull request
Oct 25, 2025
…ta-pytorch#396) Co-authored-by: Felipe Mello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove old SFT related metric logging system and replaces with new based on monarch
notes:
a) Epoch brief fluctuation can happen because of how we shard the data. Datasets are infinite, and its possible that while 1 shard was exhausted, another shard from epoch 0 was not.
b) need to follow up to add perf metrics to measure training time and max memory