Skip to content

integrate torchcomms #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

integrate torchcomms #290

wants to merge 1 commit into from

Conversation

@tushar00jain
Copy link
Contributor

@tushar00jain tushar00jain commented Nov 7, 2025

Differential Revision: D86343575

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 7, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 7, 2025

@tushar00jain has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86343575.

tushar00jain added a commit to tushar00jain/torchft that referenced this pull request Nov 7, 2025
@tushar00jain @facebook-github-bot
integrate torchcomms (meta-pytorch#290)
7f87b9b 
Summary: Pull Request resolved: meta-pytorch#290

Differential Revision: D86343575
tushar00jain added a commit to tushar00jain/torchft that referenced this pull request Nov 7, 2025
@tushar00jain @facebook-github-bot
integrate torchcomms (meta-pytorch#290)
1aaf823 
Summary: Pull Request resolved: meta-pytorch#290

Differential Revision: D86343575
tushar00jain added a commit to tushar00jain/torchft that referenced this pull request Nov 7, 2025
@tushar00jain @facebook-github-bot
integrate torchcomms (meta-pytorch#290)
e84109a 
Summary: Pull Request resolved: meta-pytorch#290

Differential Revision: D86343575
tushar00jain added a commit to tushar00jain/torchft that referenced this pull request Nov 7, 2025
@tushar00jain @facebook-github-bot
integrate torchcomms (meta-pytorch#290)
9925753 
Summary: Pull Request resolved: meta-pytorch#290

Differential Revision: D86343575
tushar00jain added a commit to tushar00jain/torchft that referenced this pull request Nov 10, 2025
@tushar00jain @facebook-github-bot
integrate torchcomms (meta-pytorch#290)
c77cb58 
Summary: Pull Request resolved: meta-pytorch#290

Differential Revision: D86343575
tushar00jain added a commit to tushar00jain/torchft that referenced this pull request Nov 10, 2025
@tushar00jain @facebook-github-bot
integrate torchcomms (meta-pytorch#290)
0533602 
Summary:

- add torchcomms integration
- instsall torchcomms in build files
- add a class that wraps torchcomms to offer reconfiguration and timeout handline just like process group wrapper
- allow users to pass either torchcomms or pg to manager -- manager infers the type and calls the relevant api's
- had to work around torchcomms not having get_future api -- since futures are lazy in manager, we can just creae a dummy future and set the value on it since we modify the vlaue in place

Differential Revision: D86343575
tushar00jain added a commit to tushar00jain/torchft that referenced this pull request Nov 10, 2025
@tushar00jain @facebook-github-bot
integrate torchcomms (meta-pytorch#290)
fa06913 
Summary:

- add torchcomms integration
- instsall torchcomms in build files
- add a class that wraps torchcomms to offer reconfiguration and timeout handline just like process group wrapper
- allow users to pass either torchcomms or pg to manager -- manager infers the type and calls the relevant api's
- had to work around torchcomms not having get_future api -- since futures are lazy in manager, we can just creae a dummy future and set the value on it since we modify the vlaue in place

Differential Revision: D86343575
tushar00jain added a commit to tushar00jain/torchft that referenced this pull request Nov 11, 2025
@tushar00jain @facebook-github-bot
integrate torchcomms (meta-pytorch#290)
4822fa3 
Summary:

- add torchcomms integration
- instsall torchcomms in build files
- add a class that wraps torchcomms to offer reconfiguration and timeout handline just like process group wrapper
- allow users to pass either torchcomms or pg to manager -- manager infers the type and calls the relevant api's
- had to work around torchcomms not having get_future api -- since futures are lazy in manager, we can just creae a dummy future and set the value on it since we modify the vlaue in place

Differential Revision: D86343575
tushar00jain added a commit to tushar00jain/torchft that referenced this pull request Nov 11, 2025
@tushar00jain @facebook-github-bot
integrate torchcomms (meta-pytorch#290)
f77c294 
Summary:

- add torchcomms integration
- instsall torchcomms in build files
- add a class that wraps torchcomms to offer reconfiguration and timeout handline just like process group wrapper
- allow users to pass either torchcomms or pg to manager -- manager infers the type and calls the relevant api's
- had to work around torchcomms not having get_future api -- since futures are lazy in manager, we can just creae a dummy future and set the value on it since we modify the vlaue in place

Differential Revision: D86343575
@tushar00jain @facebook-github-bot
integrate torchcomms (meta-pytorch#290)
b27951b 
Summary:

- add torchcomms integration
- instsall torchcomms in build files
- add a class that wraps torchcomms to offer reconfiguration and timeout handline just like process group wrapper
- allow users to pass either torchcomms or pg to manager -- manager infers the type and calls the relevant api's
- had to work around torchcomms not having get_future api -- since futures are lazy in manager, we can just creae a dummy future and set the value on it since we modify the vlaue in place

Differential Revision: D86343575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tushar00jain