fix a corner-case bug in memory snapshot uploading #3504
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@TroyGarden has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86051540. |
Summary: # context * loglevel is not correctly set in train pipeline benchmark due to the multiprocess setup * the log level is only set in the main process but not correctly set in the forked/spawn processes * this diff add the `loglevel` argument into the RunConfig so that in every runner funcion can call `set_logger_level` * also directly pass the error message on yaml or json parser failure, which previously just warn silently and the warning message is buried in lengthy logs. * with loglevel=info we can now see the planner info: P2014482201 Differential Revision: D85829837
Summary: Fixed two corner case issues in the TorchRec benchmark utilities: 1. **Memory snapshot handling**: Added rank filtering for memory snapshot operations to ensure they only run on rank 0 or when `all_rank_traces` is enabled. This prevents redundant memory snapshots from being taken on all ranks, reducing overhead and storage requirements while still capturing the necessary profiling data. 2. **Shell script robustness**: Added file existence checks before loop iterations in the trace upload script. Previously, if no trace files or memory snapshot files were found, the script would fail silently or produce errors. Now it checks with `ls` first and only proceeds with the loop if files exist, preventing issues when the trace directory is empty or files don't match the expected patterns. Differential Revision: D86051540
TroyGarden
force-pushed
the
export-D86051540
branch
from
11c75e7 to
d2ce78f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed two corner case issues in the TorchRec benchmark utilities:
Memory snapshot handling: Added rank filtering for memory snapshot operations to ensure they only run on rank 0 or when
all_rank_tracesis enabled. This prevents redundant memory snapshots from being taken on all ranks, reducing overhead and storage requirements while still capturing the necessary profiling data.Shell script robustness: Added file existence checks before loop iterations in the trace upload script. Previously, if no trace files or memory snapshot files were found, the script would fail silently or produce errors. Now it checks with
lsfirst and only proceeds with the loop if files exist, preventing issues when the trace directory is empty or files don't match the expected patterns.Differential Revision: D86051540