Allow aliases for run_opt #1141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
=======================================
Coverage 91.64% 91.65%
=======================================
Files 83 83
Lines 6441 6482 +41
=======================================
+ Hits 5903 5941 +38
- Misses 538 541 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 8, 2025
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. 1. Modify add() to accept this and add a new optional aliases List[str] that will store this. 2. Modify resolve() to check if a different alias is already used in cfg i.e if the "run_as" and "Run_As" are aliases for the same one, we dont allow for both to be present in the cfg. Differential Revision: D84157870
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 8, 2025
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. 1. Modify add() to accept this and add a new optional aliases List[str] that will store this. 2. Modify resolve() to check if a different alias is already used in cfg i.e if the "run_as" and "Run_As" are aliases for the same one, we dont allow for both to be present in the cfg. Differential Revision: D84157870
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 9, 2025
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. 1. Modify add() to accept this and add a new optional aliases List[str] that will store this. 2. Modify resolve() to check if a different alias is already used in cfg i.e if the "run_as" and "Run_As" are aliases for the same one, we dont allow for both to be present in the cfg. Differential Revision: D84157870
AbishekS
force-pushed
the
export-D84157870
branch
from
a5a9be2 to
3f66cd6
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 9, 2025
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. 1. Add a new dict to maintain alias to key values that can be used by `opt.get(name)` 2. Modify add() to accept list as well, build out the aliases list and modify the previously created dict to fill in alias to primary_key values. 3. Modify resolve() to check if a different alias is already used in cfg i.e if the "jobPriority" and "job_priority" are aliases for the same one, we don't allow for both to be present in the cfg. 4. Modify get to look at the alias to primary_key dict as well. Differential Revision: D84157870
AbishekS
force-pushed
the
export-D84157870
branch
from
3f66cd6 to
8056935
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 9, 2025
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. * Introduce new class for `RunOptAlias` which is used to expand on adding aliases to a runopt. * Add a new dict to maintain alias to key values that can be used by `opt.get(name)` * Modify add() to accept list as well, build out the aliases list and modify the previously created dict to fill in alias to primary_key values. * Modify resolve() to check if a different alias is already used in cfg i.e if the "jobPriority" and "job_priority" are aliases for the same one, we don't allow for both to be present in the cfg. * Modify get to look at the alias to primary_key dict as well. Differential Revision: D84157870
AbishekS
force-pushed
the
export-D84157870
branch
from
8056935 to
d4bcff2
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. * Introduce new class for `RunOptAlias` which is used to expand on adding aliases to a runopt. * Add a new dict to maintain alias to key values that can be used by `opt.get(name)` * Modify add() to accept list as well, build out the aliases list and modify the previously created dict to fill in alias to primary_key values. * Modify resolve() to check if a different alias is already used in cfg i.e if the "jobPriority" and "job_priority" are aliases for the same one, we don't allow for both to be present in the cfg. * Modify get to look at the alias to primary_key dict as well. Differential Revision: D84157870
AbishekS
force-pushed
the
export-D84157870
branch
from
d4bcff2 to
56a3ed7
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. * Introduce new class for `RunOptAlias` which is used to expand on adding aliases to a runopt. * Add a new dict to maintain alias to key values that can be used by `opt.get(name)` * Modify add() to accept list as well, build out the aliases list and modify the previously created dict to fill in alias to primary_key values. * Modify resolve() to check if a different alias is already used in cfg i.e if the "jobPriority" and "job_priority" are aliases for the same one, we don't allow for both to be present in the cfg. * Modify get to look at the alias to primary_key dict as well. Differential Revision: D84157870
AbishekS
force-pushed
the
export-D84157870
branch
from
56a3ed7 to
b688071
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. * Introduce new class for `RunOptAlias` which is used to expand on adding aliases to a runopt. * Add a new dict to maintain alias to key values that can be used by `opt.get(name)` * Modify add() to accept list as well, build out the aliases list and modify the previously created dict to fill in alias to primary_key values. * Modify resolve() to check if a different alias is already used in cfg i.e if the "jobPriority" and "job_priority" are aliases for the same one, we don't allow for both to be present in the cfg. * Modify get to look at the alias to primary_key dict as well. Differential Revision: D84157870
AbishekS
force-pushed
the
export-D84157870
branch
from
b688071 to
d60c13c
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. * Introduce new class for `runopt.alias` which is used to expand on adding aliases to a runopt. * Add a new dict to maintain alias to key values that can be used by `opt.get(name)` * Modify add() to accept list as well, build out the aliases list and modify the previously created dict to fill in alias to primary_key values. * Modify resolve() to check if a different alias is already used in cfg i.e if the "jobPriority" and "job_priority" are aliases for the same one, we don't allow for both to be present in the cfg. * Modify get to look at the alias to primary_key dict as well. Differential Revision: D84157870
AbishekS
force-pushed
the
export-D84157870
branch
from
d60c13c to
c197595
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. * Introduce new class for `runopt.alias` which is used to expand on adding aliases to a runopt. * Add a new dict to maintain alias to key values that can be used by `opt.get(name)` * Modify add() to accept list as well, build out the aliases list and modify the previously created dict to fill in alias to primary_key values. * Modify resolve() to check if a different alias is already used in cfg i.e if the "jobPriority" and "job_priority" are aliases for the same one, we don't allow for both to be present in the cfg. * Modify get to look at the alias to primary_key dict as well. Differential Revision: D84157870
AbishekS
force-pushed
the
export-D84157870
branch
from
c197595 to
809006f
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. * Introduce new class for `runopt.alias` which is used to expand on adding aliases to a runopt. * Add a new dict to maintain alias to key values that can be used by `opt.get(name)` * Modify add() to accept list as well, build out the aliases list and modify the previously created dict to fill in alias to primary_key values. * Modify resolve() to check if a different alias is already used in cfg i.e if the "jobPriority" and "job_priority" are aliases for the same one, we don't allow for both to be present in the cfg. * Modify get to look at the alias to primary_key dict as well. Differential Revision: D84157870
AbishekS
force-pushed
the
export-D84157870
branch
2 times, most recently
from
4761f4b to
3514284
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. * Introduce new class for `runopt.alias` which is used to expand on adding aliases to a runopt. * Add a new dict to maintain alias to key values that can be used by `opt.get(name)` * Modify add() to accept list as well, build out the aliases list and modify the previously created dict to fill in alias to primary_key values. * Modify resolve() to check if a different alias is already used in cfg i.e if the "jobPriority" and "job_priority" are aliases for the same one, we don't allow for both to be present in the cfg. * Modify get to look at the alias to primary_key dict as well. Differential Revision: D84157870
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. * Introduce new class for `runopt.alias` which is used to expand on adding aliases to a runopt. * Add a new dict to maintain alias to key values that can be used by `opt.get(name)` * Modify add() to accept list as well, build out the aliases list and modify the previously created dict to fill in alias to primary_key values. * Modify resolve() to check if a different alias is already used in cfg i.e if the "jobPriority" and "job_priority" are aliases for the same one, we don't allow for both to be present in the cfg. * Modify get to look at the alias to primary_key dict as well. Differential Revision: D84157870
AbishekS
force-pushed
the
export-D84157870
branch
from
3514284 to
3159f21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt.
Differential Revision: D84157870