Remove large-int-id String serialization middleware [DO NOT MERGE YET]
#44791
+19
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsaul
changed the title
large-int-id middlewarelarge-int-id middleware [DO NOT MERGE YET]
camsaul
changed the title
large-int-id middleware [DO NOT MERGE YET]large-int-id String serialization middleware [DO NOT MERGE YET]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for #5816
Since JS stores all numbers as 64-bit doubles by default it can't parse integer literals larger than
9007199254740991in JSON query results. As a hack we serialized those numbers to strings. Going forward we'll just tweak our JSON parser to parse them toBigInts instead.This PR removes the icky middleware that serialized large integers to strings. The main goal here is to see if any backend tests break and need to be updated, or if we have e2e tests around this stuff
See Slack discussion https://metaboat.slack.com/archives/C04DN5VRQM6/p1719433869236109