fix: limit xrays on agg models to source fields #44863
Open
+52
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #43793 1. `table-like?` was checking aggregations but not breakouts. This meant that legacy metric definitions would try to apply to the second stage which is generally illegal and would cause things like implicit joins to come in where they make no sense. 2. Trying to bin a `count` metric-like model would give a bin span of 0.0 which would blow up those questions. 3. Trying to self reference breakout fields, in the precense of a question's aggregation meant that most fields would not be exposed to the next stage and should be ignored. (similar to 1.)
snoe
added
backport
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43793
table-like?was checking aggregations but not breakouts. This meant that legacy metric definitions would try to apply to the second stage which is generally illegal and would cause things like implicit joins to come in where they make no sense.countmetric-like model would give a bin span of 0.0 which would blow up those questions.