Merge pull request #3000 from metabrainz/LB-1635

LB-1635: Navigation history broken when clicking on a user's stats
metabrainz · Oct 21, 2024 · 0dc2ca2 · 0dc2ca2
2 parents 4ac93f1 + bf40599
commit 0dc2ca2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/frontend/js/src/search/Search.tsx b/frontend/js/src/search/Search.tsx
@@ -25,7 +25,10 @@ export default function Search() {
 
   React.useEffect(() => {
     if (invalidSearchTypes(searchType)) {
-      setSearchParams({ search_term: searchTerm, search_type: "artist" });
+      setSearchParams(
+        { search_term: searchTerm, search_type: "artist" },
+        { replace: true }
+      );
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [searchType]);

diff --git a/frontend/js/src/user/stats/UserReports.tsx b/frontend/js/src/user/stats/UserReports.tsx
@@ -44,7 +44,7 @@ export default function UserReports() {
 
   React.useEffect(() => {
     if (!range || isInvalidStatRange(range)) {
-      setSearchParams({ range: "week" });
+      setSearchParams({ range: "week" }, { replace: true });
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [range]);