Removed unused elemts from props, fixed linting errors

metabrainz · Jan 15, 2025 · 1faccbe · 1faccbe
1 parent 7fd2c7d
commit 1faccbe
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 11 deletions.
diff --git a/frontend/js/src/common/brainzplayer/BrainzPlayerUI.tsx b/frontend/js/src/common/brainzplayer/BrainzPlayerUI.tsx
@@ -263,7 +263,7 @@ function BrainzPlayerUI(props: React.PropsWithChildren<BrainzPlayerUIProps>) {
             disabled={disabled}
           />
         </div>
-        <VolumeControlButton volume={volume} />
+        <VolumeControlButton />
         <div className="actions">
           {isPlayingATrack && currentDataSourceName && (
             <a

diff --git a/frontend/js/src/common/brainzplayer/SoundcloudPlayer.tsx b/frontend/js/src/common/brainzplayer/SoundcloudPlayer.tsx
@@ -154,7 +154,10 @@ export default class SoundcloudPlayer
 
   componentDidUpdate(prevProps: DataSourceProps) {
     const { show, volume } = this.props;
-    this.soundcloudPlayer?.setVolume((volume ?? 100) / 100);
+    if (this.soundcloudPlayer?.setVolume) {
+      this.soundcloudPlayer?.setVolume((volume ?? 100) / 100);
+    }
+
     if (prevProps.show && !show && this.soundcloudPlayer) {
       this.soundcloudPlayer.pause();
     }

diff --git a/frontend/js/src/common/brainzplayer/SpotifyPlayer.tsx b/frontend/js/src/common/brainzplayer/SpotifyPlayer.tsx
@@ -143,7 +143,9 @@ export default class SpotifyPlayer
 
   componentDidUpdate(prevProps: DataSourceProps) {
     const { show, volume } = this.props;
-    this.spotifyPlayer?.setVolume((volume ?? 100) / 100);
+    if (this.spotifyPlayer?.setVolume) {
+      this.spotifyPlayer?.setVolume((volume ?? 100) / 100);
+    }
 
     if (prevProps.show === true && show === false) {
       this.stopAndClear();

diff --git a/frontend/js/src/common/brainzplayer/VolumeControlButton.tsx b/frontend/js/src/common/brainzplayer/VolumeControlButton.tsx
@@ -1,11 +1,7 @@
 import * as React from "react";
 import { useBrainzPlayerDispatch } from "./BrainzPlayerContext";
 
-type VolumeControlButtonProps = {
-  volume: number;
-};
-
-function VolumeControlButton(props: VolumeControlButtonProps) {
+function VolumeControlButton() {
   const dispatch = useBrainzPlayerDispatch();
   const volumeRef = React.useRef<HTMLInputElement>(null);
   const handleVolumeChange = () => {

diff --git a/frontend/js/src/common/brainzplayer/YoutubePlayer.tsx b/frontend/js/src/common/brainzplayer/YoutubePlayer.tsx
@@ -120,7 +120,9 @@ export default class YoutubePlayer extends React.Component<YoutubePlayerProps>
 
   componentDidUpdate(prevProps: DataSourceProps) {
     const { show, volume } = this.props;
-    this.youtubePlayer?.setVolume(volume ?? 100);
+    if (this.youtubePlayer?.setVolume) {
+      this.youtubePlayer?.setVolume(volume ?? 100);
+    }
     if (prevProps.show && !show && this.youtubePlayer) {
       this.youtubePlayer.stopVideo();
       // Clear playlist

diff --git a/frontend/js/tests/common/brainzplayer/SoundcloudPlayer.test.tsx b/frontend/js/tests/common/brainzplayer/SoundcloudPlayer.test.tsx
@@ -26,7 +26,6 @@ const defaultContext = {
 
 const props = {
   show: true,
-  volume: 100,
   playerPaused: false,
   refreshSoundcloudToken: new APIService("base-uri").refreshSoundcloudToken,
   onPlayerPausedChange: (paused: boolean) => {},

diff --git a/frontend/js/tests/common/brainzplayer/YoutubePlayer.test.tsx b/frontend/js/tests/common/brainzplayer/YoutubePlayer.test.tsx
@@ -8,7 +8,6 @@ import APIService from "../../../src/utils/APIService";
 
 const props = {
   show: true,
-  volume: 100,
   playerPaused: false,
   youtubeUser: {
     api_key: "fake-api-key",