Fix failing server test

Fix `listenbrainz/tests/integration/test_user_timeline_event_api.py::UserTimelineAPITestCase::test_personal_recommendation_writes_to_db`, ensure ordering of recommended users is maintained for personal recommendation events.
metabrainz · Dec 27, 2023 · 952d957 · 952d957
1 parent a1479a3
commit 952d957
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/listenbrainz/db/user_timeline_event.py b/listenbrainz/db/user_timeline_event.py
@@ -126,10 +126,10 @@ def create_personal_recommendation_event(user_id: int, metadata: PersonalRecordi
                             'recording_mbid', :recording_mbid,
                             'recording_msid', :recording_msid,
                             'users', (
-                                SELECT jsonb_agg("user".id) as users
-                                  FROM unnest(:users) as arr
+                                SELECT jsonb_agg("user".id ORDER BY idx) as users
+                                  FROM unnest(:users) WITH ORDINALITY as arr (value, idx)
                             INNER JOIN "user"
-                                    ON "user".musicbrainz_id = arr
+                                    ON "user".musicbrainz_id = value
                             ),
                             'blurb_content', :blurb_content
                         )