Year in Music 2023 #2668
Merged
Year in Music 2023 #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @MonkeyDo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-01-03 11:32:04 UTC |
amCap1712
reviewed
Dec 15, 2023
listenbrainz/webserver/templates/art/svg-templates/yim-2023-playlist-hug.svg
Outdated
Show resolved
Hide resolved
+ refactor missing data management
Handle cases where not enough stats are present better, fix a few broken checks for stats image and remove some redundant paths.
Currently will not show the correct cover art composite image, which we will need to host on StaticBrainz under staticbrainz.org/LB/year-in-music/2023/mosaic-2023.jpg We will also need /mosaic-2023-small.jpg , /mosaic-2023-medium.jpg and /mosaic-2023-large.jpg
pesky "display: table" style left over from last year's YIM component
For some reason the height is 0 in Firefox. The other graphs work fine.
for firefox
Garbled the previous one during copy paste
The utility we use to render SVGs (Canvg) does not take the `letter-spacing` property into account, and we need to customize the kerning manually using the `dx` attribute For reference: canvg/canvg#668
cropped a little tight
In the ListenCard component, if we have no info at all to display any cover art, ensure there is a an empty thumbnail element to maintain text alignment with other listencards with cover art
Woopsie ! I needed to change the margin rather than the padding, which refers to the padding between each bar. When = 1, no bars are shown at all.
Improving mobile phone layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This year's YIM page rolled up into one big PR, just the way we like it !
As with previous years, it is my opinion that creating a test suite for this yearly feature is not particularly necessary and very time consuming for the projected lifetime of the feature.
Here is a list of what we are still currently missing, using the figma design document and the checklist document as a reference:
coming soon placeholder page -(monkey: haven't had time to set it up but should be easy, should have time in the next few days)Ran out of time+top navbarlinks to YIM23 (monkey, end of the month)"friends" section at the bottom: we could show a piece of info from 's friends' YIM report, as in the mockup, if that's not too much data to fetchRan out of time