LB-1411: Add mediums to release group metadata cache #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @amCap1712! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-01-06 12:41:35 UTC |
amCap1712
commented
Dec 27, 2023
| ujson.dumps({"release_mbid": str(row["recordings_release_mbid"]), "recordings": recordings})) | ||
| ujson.dumps({ | ||
| "release_mbid": str(row["recordings_release_mbid"]), | ||
| "recordings": all_recordings, |
There was a problem hiding this comment.
recordings are stored twice in release group metadata cache at the moment for backward compatibility, this can be removed as soon as this PR is deployed to production.
amCap1712
force-pushed
the
release-group-listeners-fix
branch
from
2ab9b51 to
4b40671
Compare
amCap1712
force-pushed
the
add-medium-to-release-group-cache
branch
2 times, most recently
from
7fef108 to
2a1208f
Compare
amCap1712
force-pushed
the
add-medium-to-release-group-cache
branch
2 times, most recently
from
9959dc5 to
1818e2e
Compare
MonkeyDo
approved these changes
Jan 3, 2024
Store mediums in release group metadata cache so that tracklists for releases with multiple discs are displayed properly.
amCap1712
force-pushed
the
add-medium-to-release-group-cache
branch
from
1818e2e to
1636c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store mediums in release group metadata cache so that tracklists for releases with multiple discs are displayed properly.