Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental stats entity #3116

Merged
merged 10 commits into from
Jan 24, 2025
Merged

Incremental stats entity #3116

merged 10 commits into from
Jan 24, 2025

Conversation

amCap1712
Copy link
Member

@amCap1712 amCap1712 commented Jan 7, 2025

Builds on #3115 and incrementalizes entity stats.

@pep8speaks
Copy link

pep8speaks commented Jan 7, 2025

Hello @amCap1712! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2025-01-24 13:08:08 UTC

@amCap1712 amCap1712 force-pushed the incremental-stats-user branch from 9e0b43b to 3a5366e Compare January 8, 2025 16:25
@amCap1712 amCap1712 force-pushed the incremental-stats-entity branch from d01ffde to 11eb30b Compare January 9, 2025 16:51
@amCap1712 amCap1712 force-pushed the incremental-stats-user branch from 824883d to 9430bc7 Compare January 9, 2025 19:36
@amCap1712 amCap1712 force-pushed the incremental-stats-entity branch 2 times, most recently from ca911bc to f376920 Compare January 10, 2025 08:04
@amCap1712 amCap1712 force-pushed the incremental-stats-user branch from e410b85 to da8255a Compare January 22, 2025 09:33
@amCap1712 amCap1712 force-pushed the incremental-stats-entity branch from 42921a1 to 1714442 Compare January 24, 2025 12:26
Base automatically changed from incremental-stats-user to master January 24, 2025 12:58
@amCap1712 amCap1712 force-pushed the incremental-stats-entity branch from 1714442 to 1c57530 Compare January 24, 2025 12:59
@amCap1712 amCap1712 marked this pull request as ready for review January 24, 2025 13:03
Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, much easier to review than last one.

@amCap1712 amCap1712 merged commit 576f9d8 into master Jan 24, 2025
2 of 3 checks passed
@amCap1712 amCap1712 deleted the incremental-stats-entity branch January 24, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants