Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB-1718: fix top discoveries playlist #3123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amCap1712
Copy link
Member

To find tracks discovered in a year correctly, need to use all listens.

To find tracks discovered in a year correctly, need to use all listens.
@amCap1712 amCap1712 requested a review from mayhem January 10, 2025 17:45
@mwiencek
Copy link
Member

mwiencek commented Jan 10, 2025

I wondered if a similar issue caused https://community.metabrainz.org/t/year-in-music-2024/735268/6 but you do use LAST_FM_FOUNDING_YEAR in get_new_artists_discovered_count at least. 🤷 (My YIM also says I have 91% new artists discovered which is definitely wrong, with Last.fm giving 36%.)

@amCap1712
Copy link
Member Author

Ah my bad! 🤦. I used a partial dump to generate YIM because the full dump takes over a day to generate and import but I forgot there are things that need the full dump.

Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good, I had some questionable items in that playlist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants