-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved marks mapping #3142
base: master
Are you sure you want to change the base?
Improved marks mapping #3142
Conversation
Hehe, great minds think alike ! I've done a similar change in #3138 However that PR also puts in a date whenever a week has passed, I thought it might be useful to avoid having huge gaps in the timeline, but I think it might make it worse in the end. I'll check your solution and see which one works best. |
So this is pretty similar results to what I tried myself, and while it improves the timeline I think there are still issues that I don't know how to solve. I think the solution would instead be to roll out our own component where we can control things a bit better. That leaves us with creating the component and styles, and reacting to page scroll/click on the timeline What do you think about that plan? |
Originally I was thinking with the idea of anchor tags but didn't feel like changing the entire thing but surely I can work on it, do share your trials will get on to it right away. |
One of the problems with anchor tags is that once the user redirects himself, the scroll will automatically move here and there from the date due to the percentage implementation, any idea on how to resolve that? |
I don't think I understand what you mean by "redirects himself". Do you mean that there will be a mismatch between the vertical placement of the dates in the timeline and the actual position of the "cursor" (the position indicator) on the timeline? |
Yes that's what I mean that the placement won't be the same, do you think we could ignore the threshold part and just make it equally distributed than total releases focused, the only problem with that will be the concept behind which date has more releases. |
I think you can go ahead without worrying too much about the placement of dates on the timeline. |
Problem
Sidebar with Date marks didn't map to the date accurately on the
/explore/fresh-releases/
page.Solution
Modified the method of percentage calculation to accommodate a better mapping to the date searched for by the user.
Action