Incremental Stats deployment fixes #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the database for each stat is generated and the previous database for the same stat is deleted daily. However, incremental stats generates messages only for users with listens in incremental dumps, assuming stats for users without new listens are already available on the LB server. To maintain this assumption, each stats database must have a fixed name. Therefore, avoid sending the database name from the LB server to Spark in stat generation requests. During stats generation, Spark determines whether it's a full or incremental generation. For full stats, a new database name is created and sent; for incremental stats, a database prefix is sent for the LB server to look up the existing database and insert the stats accordingly.
amCap1712
force-pushed
the
incremental-cleanup
branch
from
40f80ec to
18ef743
Compare
|
For listening activity, a CROSS JOIN is needed to add rows for days on which the user didn't listen to any listens. I had removed it in a previous PR due a misunderstanding. Its now added back. For the LEFT JOIN, need to pay attention on which table attributes being join-ed on are taken from (user_id and time_range) otherwise they will be NULL for the extra added rows. |
mayhem
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the database for each stat is generated and the previous database for the same stat is deleted daily. However, incremental stats generates messages only for users with listens in incremental dumps, assuming stats for users without new listens are already available on the LB server. To maintain this assumption, each stats database must have a fixed name. Therefore, avoid sending the database name from the LB server to Spark in stat generation requests. During stats generation, Spark determines whether it's a full or incremental generation. For full stats, a new database name is created and sent; for incremental stats, a database prefix is sent for the LB server to look up the existing database and insert the stats accordingly.