Skip to content

Conversation

reosarevok
Copy link
Member

@reosarevok reosarevok commented Aug 27, 2025

Implement MBS-14120

Description

It's often quite hard to figure out the specific source for an edit entered through the relationship editor (especially when a recording is shared between multiple releases), and yet many editors (me included!) tend to forget about it and just enter notes like "See booklet on CAA" or the like.

This makes it so that edits entered from the release relationship editor get a new entered_from piece of data, allowing us to always specify what release the edit was, well, entered from.

image (3)

Testing

Manually, plus updated the release editor selenium tests.

@reosarevok reosarevok added the New feature Non urgent new stuff label Aug 27, 2025
@reosarevok reosarevok force-pushed the MBS-14120 branch 6 times, most recently from 6a8f511 to aa99271 Compare September 3, 2025 17:33
@reosarevok reosarevok changed the title [WIP] MBS-14120: Indicate the edited release on edits entered from the relationship editor MBS-14120: Indicate the edited release on edits entered from the relationship editor Sep 3, 2025
@reosarevok reosarevok marked this pull request as ready for review September 3, 2025 18:43
Copy link
Member

@mwiencek mwiencek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great for me, but we need some validation for enteredFrom in WS::js::Edit. The provided entity_type + gid should resolve to a real entity. Right now anyone could submit junk that just crashes the edit listings.

It's often quite hard to figure out the specific source for an edit
entered through the relationship editor (especially when a recording
is shared between multiple releases), and yet many editors
(me included!) tend to forget about it and just enter notes like
"See booklet on CAA" or the like.

This makes it so that edits entered from the release relationship
editor get a new entered_from piece of data, allowing us to always
specify what release the edit was, well, entered from.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New feature Non urgent new stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants