MBS-14224: Add myanimelist.net to the otherdbs whitelist #3696
+75
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
reviewed
Jan 5, 2026
reosarevok
approved these changes
Jan 5, 2026
Member
reosarevok
left a comment
reosarevok
left a comment
There was a problem hiding this comment.
Looks good to me, quickly tested locally that the links are cleaned up and the favicons show.
Member
|
And now fixed the minor eslint issues that had triggered the tests :) Let's see if they pass now. |
reosarevok
reviewed
Jan 6, 2026
mwiencek
approved these changes
Jan 13, 2026
|
Congratulations on your first merged pull request for MusicBrainz Server! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As also described in STYLE-1102
MyAnimeList is a manga and anime cataloging website that also has entries for voice actors, theme song performers and staff.
Artist links:
https://myanimelist.net/people/185 when talking about a person (artist).
https://myanimelist.net/character/40 when talking about a character (artist).
Label links:
https://myanimelist.net/anime/producer/1696 when talking about a company (label)
Unnormalized link examples:
https://myanimelist.net/people/185/Kana_Hanazawa
https://myanimelist.net/character/40/Luffy_Monkey_D
https://myanimelist.net/anime/producer/1696/Kadokawa
Testing
Added MyAnimeList entries to URLCleanup.js tests, otherwise tested manually on artist and label page.