Skip to content

Conversation

@SuperSaltyGamer
Copy link
Contributor

Implementation for MBS-14225

Description

  • Implemented validation for Mora link type against MusicBrainz entity type.
  • Implemented artist link cleanup. Previously artist links were not cleaned up at all due to the hardcoded "/package/" segment in the regex.
  • Implemented track link cleanup. Previously track links were cleaned up as release links making them invalid for recordings.

Testing

Added artist and track entries to URLCleanup.js tests, otherwise tested manually on artist, recording and release pages.

Further action

As also mentioned in the ticket, there are some unnormalized/incorrect links already in the database that should be dealt with.

Total unnormalized artist and release links: ~500
Total incorrect artist links: ~50
Total incorrect recording links: ~150

Artist links can easily be manually updated, but release and recording links are more tricky. It also seems like most if not all recording links added so far are incorrect.

@welcome
Copy link

welcome bot commented Jan 3, 2026

Thanks for opening your first pull request for MusicBrainz Server, and welcome to our community! 🎉
If you haven’t yet, please check out our contributing guidelines.
Someone will be reviewing your PR soon; just hang in there!
In the meantime, if you’re wondering what to do next, you can have a look at our issue tracker.

Copy link
Member

@reosarevok reosarevok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMBDNT

@reosarevok reosarevok merged commit e72c8a8 into metabrainz:master Jan 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants