MBS-14231: Block API POST of tags with commas #3702
Merged
+81
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our tag UI on the website does not support tags with commas, and our tags are documented to be comma-separated. At the same time, nothing in the API is blocking submitting tags with commas in POST submissions, which later get "stuck" since they cannot be voted on nor withdrawn on the website itself. This implements what seems to be the obvious solution: rejecting the submission of tags with commas entirely also via the API. I left an exception for "withdraw" votes, since removing tags with commas seems entirely safe and makes it a bit easier to clean any existing tags (there seem to be only 52 tags with commas at the moment though).
Member
Author
|
I would suggest MBS-8697 can be closed if we have removed all the existing ways of submitting tags with commas (which hopefully this is the last of). What do you think? |
Member
I'd agree for now unless someone can document an important use-case for tags with commas. I do like the idea of them being completely free-form, but they should at least be disallowed while they break our UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-14231
Problem
Our tag UI on the website does not support tags with commas, and our tags are documented to be comma-separated. At the same time, nothing in the API is blocking submitting tags with commas in POST submissions, which later get "stuck" since they cannot be voted on nor withdrawn on the website itself.
Solution
This implements what seems to be the obvious solution: rejecting the submission of tags with commas entirely also via the API.
I left an exception for "withdraw" votes, since removing tags with commas seems entirely safe and makes it a bit easier to clean any existing tags (there seem to be only 52 tags with commas at the moment though, see this gist).
Testing
Manually with my local server, plus added some basic tests here.