Refactor markdown rendering to be viewed using /view/ URLs #3487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarg
force-pushed
the
haarg/markdown-refactor
branch
from
ea2ad2d to
a07f98e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3487 +/- ##
==========================================
+ Coverage 73.66% 73.87% +0.20%
==========================================
Files 67 68 +1
Lines 2354 2369 +15
Branches 333 333
==========================================
+ Hits 1734 1750 +16
Misses 497 497
+ Partials 123 122 -1
🚀 New features to boost your workflow:
|
haarg
force-pushed
the
haarg/markdown-refactor
branch
from
a07f98e to
31503f7
Compare
content is too generic of a name for what we've been using it for. It conflicts with a class name sometimes used by the syntax highlighter.
An IO::Async::Loop subclass is likely to have circular references, which causes problems with Data::Dump. Data::Dump is used by Catalyst do output debug info. Add a filter to show a fake loop object to allow these dumps to work properly.
This allows the /view/ URLs to show markdown files, including the full sidebar.
The source page should show source, but it was hijacked to render markdown. Now that a dedicated markdown controller exists and the rendered files can be seen on /view/ URLs, the source page can be properly restored to showing the source.
haarg
force-pushed
the
haarg/markdown-refactor
branch
from
31503f7 to
d5cd86f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the
/view/controller to recognize markdown files and use a dedicated action and template to view the rendered files. The/source/URLs are restored to properly showing the source the markdown files.