Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty indent marc:leader #556

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Pretty indent marc:leader #556

merged 3 commits into from
Sep 6, 2024

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Sep 5, 2024

Resolves #550.

@dr0i dr0i marked this pull request as ready for review September 5, 2024 12:55
blackwinter
blackwinter reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to extract getIndentationPrefix() and then use it directly in writeLeader() (and prettyPrintIndentation()). No need for all these private methods that are only called once anyway.

@blackwinter blackwinter assigned dr0i and unassigned blackwinter Sep 5, 2024
@dr0i
Copy link
Member Author

dr0i commented Sep 5, 2024

I don't know what you mean with getIndentationPrefix. Feel free to implement , if you like?

@dr0i dr0i assigned blackwinter and unassigned dr0i Sep 5, 2024
@blackwinter
Copy link
Member

Done in 066a483.

@blackwinter blackwinter self-requested a review September 6, 2024 13:51
@blackwinter blackwinter assigned dr0i and unassigned blackwinter Sep 6, 2024
@dr0i dr0i merged commit fee2bcb into master Sep 6, 2024
1 check passed
@dr0i
Copy link
Member Author

dr0i commented Sep 6, 2024

Thx @blackwinter !

@dr0i dr0i deleted the 550-prettyIndentMarcLeader branch September 6, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackwinter blackwinter blackwinter approved these changes

Assignees

@dr0i dr0i

Labels
None yet
Projects
Metafacture
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encode-xml should pretty indent marc:leader
2 participants
@dr0i @blackwinter