-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "batch-reset creates empty records" #560
Conversation
functional review : @TobiasNx (see #543 (comment) for a useful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add failing tests. Every commit should pass on its own.
Either introduce the tests along with their fix, or add tests showing the wrong behaviour (including a comment to that effect) and then fix them later along with the implementation.
Note that we introduced the @MetafixToDo
annotation in metafacture-fix for exactly this purpose (see metafacture/metafacture-fix#158).
metafacture-io/src/test/java/org/metafacture/io/ObjectFileWriterTest.java
Show resolved
Hide resolved
metafacture-io/src/test/java/org/metafacture/io/ObjectFileWriterTest.java
Outdated
Show resolved
Hide resolved
By not calling the pipe (aka wrapper) but the receiver directly the stream is only once resetted when called once. (In conjunction with ObjectFileWriter and StreamBatchResetter this bug had resulted in as many empty files as non-empty ones.)
16b9349
to
3724a99
Compare
3724a99
to
d3a47ee
Compare
metafacture/metafacture-core#560 Commit-Hash: d3a47eeb70166d1ffe66ffd1cf7f3926dbc89c4d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 will open a new ticket for the empty record at the end
Fixes #543.