Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for mlx NIC and micron drive firmware updates #174

Merged
merged 6 commits into from
Aug 8, 2024
Merged

Conversation

joelrebel
Copy link
Member

What does this PR do

  • Support micron 5300MAX drives and force installs.
  • A few fixes for the mlx NIC firmware utility
  • Extends the NICUpdater interface to include UpdateRequirements() which returns any pre/post firmware install requisites.

came across this when fixing up another utility
return whats defined in the const
This adds support for the 5300MAX micron drive
The force parameter is required to downgrade/reinstall firmware on a
component
The UpdateRequirements() method is implemented by the mlxup NIC update
utility
Copy link
Collaborator

@luke-jarymowycz luke-jarymowycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition with the force option.

utils/lsblk.go Show resolved Hide resolved
utils/uefi_firmware_parser.go Show resolved Hide resolved
utils/uefi_vars.go Show resolved Hide resolved
@joelrebel joelrebel merged commit 968097b into main Aug 8, 2024
6 checks passed
@joelrebel joelrebel deleted the mlx-micron branch August 8, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants