Split EL9/EL10-specific packages for RHEL 10 support#1708
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @fonta-rh. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/copilot-review |
|
Copilot code review has been requested by @Sunnatillo. Please allow a few moments for the review to be added. |
There was a problem hiding this comment.
Pull request overview
This PR updates the packages_installation Ansible role to support RHEL/CentOS Stream 10 by splitting EL9- vs EL10-specific RPM dependencies so dnf install doesn’t fail on EL10 due to removed packages.
Changes:
- Removes
genisoimageandpython3-bcryptfrom the CentOS/RHEL common package list and moves them into anel9-specific list. - Adds an
el10-specific package list that installsxorriso(as the EL10 replacement forgenisoimage). - Adds version-gated Ansible tasks to install the new EL9/EL10 package lists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vm-setup/roles/packages_installation/tasks/main.yml | Adds EL9/EL10 conditional package installation tasks for RedHat-family hosts. |
| vm-setup/roles/packages_installation/defaults/main.yml | Splits CentOS/RHEL packages into common, el9, and el10 sections (plus existing pip3). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/test metal3-centos-e2e-integration-test-release-1-13 |
RHEL 10 / CentOS Stream 10 changes two packages from the common list: - genisoimage: replaced by xorriso (provides mkisofs compatibility) - python3-bcrypt: not available in base repos; soft dependency of passlib, not required for operation Move these to version-gated el9/el10 subsections (matching the existing Ubuntu jammy/noble pattern) so the role installs the right packages per OS major version. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Pablo Fontanilla <pfontani@redhat.com>
34739a3 to
aa58be1
Compare
Summary
genisoimageandpython3-bcryptfromcentos.common.packagesto a newcentos.el9sectioncentos.el10section withxorriso(replacesgenisoimageon EL10)main.yml, following the existing Ubuntujammy/noblepatternWhy
RHEL 10 / CentOS Stream 10 drops two packages from the common list:
genisoimage: replaced byxorriso, which provides amkisofscompatibility wrapperpython3-bcrypt: not available in RHEL 10 base repos. It's a soft dependency ofpasslib(used for password hashing) and not required — passlib has other hash backendsWithout this change,
dnf installfails on EL10 hosts because these packages don't exist.Context
Found while adding RHEL 10 provisioning host support to openshift-metal3/dev-scripts#1922. Currently worked around with
sedpatches in dev-scripts'01_install_requirements.sh— this PR fixes the issue at the source.Test plan
genisoimageandpython3-bcrypt(no regression)xorrisoinstead ofgenisoimageand skipspython3-bcrypt🤖 Generated with Claude Code