Only update assets in mpl-core collection if auth changed #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
danenbm
requested review from
kespinola,
blockiosaurus,
pmantica11 and
Nagaprasadvr
danenbm
force-pushed
the
danenbm/add-leaf-schema-version
branch
from
8c9c023 to
f9784d2
Compare
danenbm
force-pushed
the
danenbm/limit-auth-update
branch
from
f4e639a to
de7acc7
Compare
blockiosaurus
previously approved these changes
Jul 3, 2025
kespinola
reviewed
Jul 8, 2025
Comment on lines
+108
to
+128
| // If found, determine whether the authority has changed. | ||
| let collection_authority_changed = match account_data { | ||
| MplCoreAccountData::Collection(_) => { | ||
| let existing_record = asset_authority::Entity::find() | ||
| .filter(asset_authority::Column::AssetId.eq(id_vec.clone())) | ||
| .one(conn) | ||
| .await | ||
| .map_err(|db_err| ProgramTransformerError::AssetIndexError(db_err.to_string()))?; | ||
|
|
||
| // We need to update all assets in the collection if: | ||
| // 1. The collection is found and its authority has changed. | ||
| // 2. The collection is not found. | ||
| // | ||
| // Case 2 requires us to attempt to update all assets in a collection because assets | ||
| // can be indexed before the collection itself. | ||
| existing_record | ||
| .map(|record| record.authority != update_authority) | ||
| .unwrap_or(true) | ||
| } | ||
| _ => false, | ||
| }; |
There was a problem hiding this comment.
I really want to avoid doing lookups while indexing. Is there a way to do this where you join in record you want to check against and then adjusting the where class of the insert or update?
There was a problem hiding this comment.
i will look into this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Prevents updating the authority for all of the assets in an mpl-core collection for every collection change.
Instead, we update all assets in the collection if:
Case 2 requires us to attempt to update all assets in a collection because assets can be indexed before the collection itself.
Testing
collection_authority_changedcondition was triggered, since collection was not yet indexed.collection_authority_changedcondition was NOT triggered for either the collection or asset.collection_authority_changedcondition was triggered and both the collection's authority and asset's authority was updated.collection_authority_changedwas NOT triggered.