Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mvp #1

Merged
merged 45 commits into from
Dec 5, 2023
Merged

feat: mvp #1

merged 45 commits into from
Dec 5, 2023

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Nov 8, 2023

No description provided.

cli/core/hooks.ts Outdated Show resolved Hide resolved
Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, can you add GitHub action? at one points we will be able to use ghjk for its own tests

.pre-commit-config.yaml Outdated Show resolved Hide resolved
cli/hooks.ts Outdated Show resolved Hide resolved
cli/hooks.ts Outdated Show resolved Hide resolved
cli/hooks.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great!

Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow,, amazing job! Little questions/suggestions

.github/pull_request_template.md Show resolved Hide resolved
.github/workflows/pr-title-check.yml Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cli/sync.ts Outdated Show resolved Hide resolved
cli/sync.ts Outdated Show resolved Hide resolved
core/utils.ts Outdated Show resolved Hide resolved
core/utils.ts Outdated Show resolved Hide resolved
plug.ts Outdated Show resolved Hide resolved
@Yohe-Am
Copy link
Contributor Author

Yohe-Am commented Dec 2, 2023

Some comments on the refactor:

  • I've renamed Plugs to Ports to avoid the generic name.
  • Ghjk is now made up of Modules like the Ports module and the upcoming Task module.
    • Modules can expose cli subcomands
      • ghjk sync is now ghjk ports sync. Abstractions for shorthands should be possible.

LICENSE.md Outdated Show resolved Hide resolved
install/hooks/fish.fish Outdated Show resolved Hide resolved
install/hooks/fish.fish Outdated Show resolved Hide resolved
install/hooks/fish.fish Outdated Show resolved Hide resolved
install/mod.ts Outdated Show resolved Hide resolved
mod.ts Show resolved Hide resolved
tests/test.Dockerfile Outdated Show resolved Hide resolved
@Yohe-Am Yohe-Am enabled auto-merge (squash) December 4, 2023 17:27
@Yohe-Am
Copy link
Contributor Author

Yohe-Am commented Dec 4, 2023

Comments on the latest changes:

  • ZSH support is in and it's piggybacking of the mostly POSIX compliant support for bash. precmd is natively supported in ZSH so it was straightfwd.
  • The exported functions like ghjk and init_ghjk were previously there for non-interactive support as aliases are not recognized there. Exported functions were not not great either as only bash and fish properly support them and things like Shellshock means they're generally frowned upon. We're now installing an executable ghjk into the users PATH that simply calls deno run --unstable -A ghjkRepo/main.ts. This is less self-contained than before but it works well everyhwere.

Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

install/hooks/bash.sh Show resolved Hide resolved
@Yohe-Am Yohe-Am disabled auto-merge December 5, 2023 07:18
action.yml Show resolved Hide resolved
install/hooks/bash.sh Show resolved Hide resolved
install/hooks/bash.sh Show resolved Hide resolved
install/hooks/bash.sh Show resolved Hide resolved
@Yohe-Am Yohe-Am merged commit 46fa189 into main Dec 5, 2023
4 checks passed
@Yohe-Am Yohe-Am deleted the feat/mvp branch December 5, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants