Skip to content

feat(tooling): Create centralized filesystem utility - #135

Draft
google-labs-jules[bot] wants to merge 2 commits into
mainfrom
fix/filesystem-lister
Draft

feat(tooling): Create centralized filesystem utility#135
google-labs-jules[bot] wants to merge 2 commits into
mainfrom
fix/filesystem-lister

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

This change introduces a new centralized utility for filesystem operations to address systemic issues with path handling and file discovery. It includes a new filesystem_utils.py module, refactors existing tools to use it, and adds a comprehensive test suite.


PR created automatically by Jules for task 7885933632392281407

Addresses systemic issues in filesystem handling by creating a new, centralized utility for all filesystem operations.

The previous implementation had several problems:
- Inconsistent path handling across different tools.
- Duplicated file discovery logic.
- Ad-hoc, per-tool filtering and ignoring of files.
- Insufficient error handling.

This change introduces `tooling/filesystem_utils.py`, a robust module that provides a single, reliable interface for file discovery and filtering. It uses the `pathspec` library to handle `.gitignore`-style patterns correctly.

As part of this change:
- The `dependency_graph_generator.py` tool has been refactored to use the new utility, removing its custom file-walking logic.
- The `agent_shell.py` has been updated to use the new, correct filesystem lister.
- A comprehensive test suite has been added in `tests/test_filesystem_utils.py` to ensure the new utility is reliable and correct.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

@keploy

keploy Bot commented Dec 24, 2025

Copy link
Copy Markdown

To generate Unit Tests for this PR, please click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant