Support using protobuf types in query parameters #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for passing dates
|
Honestly I think a lot of this json unmarshaling in the query stuff is going to be up for the chopping block in |
|
This need to wait for
|
toctan
reviewed
Nov 6, 2020
| singlePBTypeUnmarshalTmpl := ` | ||
| var {{.LocalName}} *{{.GoType}} | ||
| {{.LocalName}} = &{{.GoType}}{} | ||
| err = jsonpb.UnmarshalString({{.LocalName}}Str, {{.LocalName}})` |
There was a problem hiding this comment.
Instead of creating thses tailored decode functions for each individual field, how about we we first merge all the variables from path, query, and body into a single JSON string, then call jsonpb.Unmarshal(s, req) to decode into the request struct in one go? Seems like it would simplify the decode logic significantly?
|
This is great! We need this to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for passing dates in the query