Skip to content

check for pre-existing parent reference - #352

Merged
mortenwh merged 15 commits into
masterfrom
fix-282
May 9, 2026
Merged

check for pre-existing parent reference#352
mortenwh merged 15 commits into
masterfrom
fix-282

Conversation

@charlienegri

Copy link
Copy Markdown
Contributor

Summary: check if a pre-existing parent exists and if it's well formed

Related issue: #282

Suggested reviewer(s):

Reviewer checklist:

  • The headers of all files contain a reference to the repository license (i.e., "License: This file is part of py-mmd-tools, licensed under the Apache License 2.0 (https://www.apache.org/licenses/LICENSE-2.0)")
  • 100% test coverage of new code - meaning:
    • The overall test coverage increased or remained the same as before
    • Every function is accompanied with a test suite
    • Tests are both positive (testing that the function work as intended with valid data) and negative (testing that the function behaves as expected with invalid data, e.g., that correct exceptions are thrown)
    • Functions with optional arguments have separate tests for all options
  • Examples are supported by doctests
  • All tests are passing
  • All names (e.g., files, classes, functions, variables) are explicit
  • Documentation (as docstrings) is complete and understandable

The checklist is based on the S-ENDA conventions and definition of done (see https://s-enda-documentation.readthedocs.io/en/latest/general_conventions.html). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.

@charlienegri
charlienegri marked this pull request as ready for review January 31, 2025 11:31
@charlienegri
charlienegri requested a review from mortenwh January 31, 2025 11:31

@mortenwh mortenwh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I suggest some minor changes to make it more explicit

Comment thread py_mmd_tools/nc_to_mmd.py Outdated
Comment thread py_mmd_tools/nc_to_mmd.py Outdated
Comment thread py_mmd_tools/nc_to_mmd.py Outdated
Comment thread py_mmd_tools/nc_to_mmd.py Outdated
Comment thread py_mmd_tools/nc_to_mmd.py Outdated
Comment thread py_mmd_tools/nc_to_mmd.py Outdated
Comment thread py_mmd_tools/nc_to_mmd.py Outdated
Comment thread py_mmd_tools/nc_to_mmd.py Outdated
charlienegri and others added 6 commits January 31, 2025 13:43
Co-authored-by: Morten W. Hansen <109061+mortenwh@users.noreply.github.com>
Co-authored-by: Morten W. Hansen <109061+mortenwh@users.noreply.github.com>
Co-authored-by: Morten W. Hansen <109061+mortenwh@users.noreply.github.com>

@mortenwh mortenwh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more - sorry...

Comment thread py_mmd_tools/nc_to_mmd.py Outdated
@mortenwh mortenwh linked an issue Jan 31, 2025 that may be closed by this pull request
@mortenwh
mortenwh merged commit 7c9b7b0 into master May 9, 2026
7 checks passed
@mortenwh
mortenwh deleted the fix-282 branch May 9, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check that the parent is not already provided in the netcdf file

2 participants