Issue357 skip layers - #359
Merged
Merged
Conversation
…layers Variables like 'relative_humidity_2m' were incorrectly excluded from WMS layer lists because 'lat' is a substring of 'relative_humidity_2m'. The test verifies that only exact coordinate variable names are filtered out. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Variables like 'relative_humidity_2m' were incorrectly excluded from WMS layers because 'lat' is a substring of 'relative_humidity_2m'. The fix uses exact matching instead of substring matching, checking both the variable name and its standard_name against the skip list. A variable named 'whatever' with standard_name 'longitude' is now also correctly excluded, even though its variable name is not in the skip list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The metno/mmd schema added a new optional element 'metadata_source' (enum: Internal | External-Harvest) to mmd_strict.xsd. This adds the corresponding entry to mmd_elements.yaml to fix the failing TestMDDElementsInYAMLAndXSD.test_mmd_element in GitHub Actions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The metno/mmd schema added storage_expiry_date (xs:date, optional) as a sub-element of storage_information_type in mmd_strict.xsd. This adds the corresponding entry to mmd_elements.yaml to fix the failing TestMDDElementsInYAMLAndXSD.test_mmd_element in GitHub Actions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: closes #357
Related issue: #357
Suggested reviewer(s):
Reviewer checklist:
The checklist is based on the S-ENDA conventions and definition of done (see https://s-enda-documentation.readthedocs.io/en/latest/general_conventions.html). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.