Fix floating-point precision artifacts in longitude normalization - #360
Merged
Conversation
When normalizing longitudes to ±180°, float arithmetic produced representation artifacts (e.g. '41.76' → '41.75999999999999'). Fix by rounding back to the original number of decimal places. Also handles numpy.float64 inputs by converting to str before inspecting decimal places. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When normalizing longitudes to ±180°, float arithmetic produced representation artifacts (e.g. '41.76' → '41.75999999999999'). Fix by rounding back to the original number of decimal places.
Also handles numpy.float64 inputs by converting to str before inspecting decimal places.
Summary: closes #358
Related issue: #358
Suggested reviewer(s):
Reviewer checklist:
The checklist is based on the S-ENDA conventions and definition of done (see https://s-enda-documentation.readthedocs.io/en/latest/general_conventions.html). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.