Eppt 2783 wind chill improver wrapper function for calculate wind chill #2217
+187
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo-robert-purvis
requested review from
brhooper,
gavinevans and
mo-robert-purvis
improver_tests/temperature/feels_like_temperature/test_feels_like_temperature.py
Outdated
Show resolved
Hide resolved
brhooper
requested changes
Oct 29, 2025
There was a problem hiding this comment.
Thanks @Anzerkhan27. I've added some comments below.
I don't know if this PR relates to a specific issue/user story for you, so I'm not in a position to check whether this actually fulfills the requirement you have. I have reviewed the code within this PR though.
improver_tests/temperature/feels_like_temperature/test_feels_like_temperature.py
Outdated
Show resolved
Hide resolved
Anzerkhan27
force-pushed
the
EPPT-2783-wind-chill-improver-wrapper-function-for-calculate-wind-chill
branch
from
5fe0b61 to
6e03510
Compare
brhooper
requested changes
Nov 5, 2025
There was a problem hiding this comment.
Thanks for making these changes @Anzerkhan27. I've added a small comment regarding the unit tests.
improver_tests/temperature/feels_like_temperature/test_feels_like_temperature.py
Outdated
Show resolved
Hide resolved
brhooper
requested changes
Nov 5, 2025
improver_tests/temperature/feels_like_temperature/test_feels_like_temperature.py
Outdated
Show resolved
Hide resolved
brhooper
approved these changes
Nov 7, 2025
There was a problem hiding this comment.
Thanks for all the changes @Anzerkhan27. I'm happy with this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Add
CalculateWindChillplugin for cube-based wind chill calculationSummary
This PR adds a new plugin class,
CalculateWindChill, withinimprover/temperature/feels_like_temperature.py.The existing
_calculate_wind_chillfunction (which operates on NumPy arrays) has been incorporated into a plugin-style class. This allows wind chill to be calculated directly from Iris cubes.Modified calculate_feels_like_temperature to use the new plugin instead of calling _calculate_wind_chill directly.
Integration
The new plugin class is added in the IMPROVER API list as: