-
Notifications
You must be signed in to change notification settings - Fork 217
WIP: delay/future/promise schemas #1171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
frenchy64
wants to merge
32
commits into
metosin:master
Choose a base branch
from
frenchy64:delay-schema
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 4 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
cd7af02
delay
frenchy64 216a709
wip
frenchy64 e433f8c
wip
frenchy64 a17fa56
wip
frenchy64 dcf6909
non-proxy schema
frenchy64 96b46f5
doc
frenchy64 6c90e3a
:future
frenchy64 2c8cecc
fix
frenchy64 84e7e49
wip
frenchy64 881da11
promise
frenchy64 b4d6f48
wip
frenchy64 e381c80
promise
frenchy64 167617e
wip
frenchy64 0e0eb62
wip
frenchy64 c79ad8f
wip
frenchy64 4027f7d
doc
frenchy64 c195dca
wip
frenchy64 cfd89dc
wip
frenchy64 1d73c5e
wip
frenchy64 f8207b0
doc
frenchy64 937e2b2
wip
frenchy64 2789044
test
frenchy64 cbdb3a1
wip
frenchy64 1b30f53
doc
frenchy64 516a300
[skip ci]
frenchy64 9aab145
wip
frenchy64 3e10318
test
frenchy64 0b882ce
fix
frenchy64 279938c
wip
frenchy64 49d90d3
bb
frenchy64 26dc44d
try
frenchy64 7008469
comment
frenchy64 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a bit off: it should fail right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main decision here is whether we should force delays during validation. Given that they often contain blocking code, it might not be the best idea. Here, I thought I'd make the default to only check if realized, and allow the user to tell malli when it's ok to force the delay via a property.