Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog for v4.12.0..master #294

Merged
merged 2 commits into from
Feb 14, 2017
Merged

Conversation

andynu
Copy link

@andynu andynu commented Jan 18, 2017

@bf4 on #292 you were asking for help with the changelog. Here's a summary of v4.12.0..master. There is a link to a comparison in the changelog that references v4.13.0 which is what I presume is next, but perhaps you consider these changes smaller. I did not change the VERSION.

@bergholdt
Copy link

@andynu we need to lock version of addressable and rainbow for 1.9.2 and 1.9.3 support.

I send you a pull request andynu#1

@@ -10,7 +10,24 @@ As such, a _Feature_ would map to either major (breaking change) or minor. A _bu
* Features
* Fixes
* Misc

### [4.13.0](https://github.com/metricfu/metric_fu/compare/v4.12.0...v4.13.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️ only add this when releasing :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon, the link or the entire title?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andynu The entire line. Maintainers will add the version when releasing. Until release, it's correct o keep under 'master' which could be renamed to 'unreleased'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. Thank you for the clarification.

@jkeam jkeam merged commit e45c184 into metricfu:master Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants