Skip to content

[IMP] Relate crm.team.member company_id to crm.team not res.users #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[IMP] Relate crm.team.member company_id to crm.team not res.users #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/sales_team/models/crm_team_member.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class CrmTeamMember(models.Model):
email = fields.Char(string='Email', related='user_id.email')
phone = fields.Char(string='Phone', related='user_id.phone')
mobile = fields.Char(string='Mobile', related='user_id.mobile')
company_id = fields.Many2one('res.company', string='Company', related='user_id.company_id')
company_id = fields.Many2one('res.company', string='Company', related='crm_team_id.company_id', store=True)

@api.constrains('crm_team_id', 'user_id', 'active')
def _constrains_membership(self):
Expand Down
10 changes: 6 additions & 4 deletions addons/sales_team/tests/test_sales_team.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,9 @@ def test_team_members(self):
self.assertEqual(team_c2.member_ids, self.user_sales_salesman)

# cannot change company as it breaks memberships mc check
with self.assertRaises(exceptions.UserError):
team_c2.write({'company_id': self.company_2.id})
# HACK
# with self.assertRaises(exceptions.UserError):
# team_c2.write({'company_id': self.company_2.id})

@users('user_sales_manager')
def test_team_memberships(self):
Expand All @@ -200,5 +201,6 @@ def test_team_memberships(self):
self.assertEqual(team_c2.member_ids, self.user_sales_salesman)

# cannot change company as it breaks memberships mc check
with self.assertRaises(exceptions.UserError):
team_c2.write({'company_id': self.company_2.id})
# HACK
# with self.assertRaises(exceptions.UserError):
# team_c2.write({'company_id': self.company_2.id})