Skip to content

Remove static UB#287

Merged
berkus merged 17 commits intodevelopfrom
fix/remove-static-ub
Sep 14, 2025
Merged

Remove static UB#287
berkus merged 17 commits intodevelopfrom
fix/remove-static-ub

Conversation

@berkus
Copy link
Copy Markdown
Member

@berkus berkus commented Jan 30, 2025

Closes #286

@berkus berkus requested a review from Copilot January 30, 2025 22:36
@berkus berkus self-assigned this Jan 30, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • machine/src/arch/aarch64/cpu/boot.s: Language not supported
  • machine/src/platform/raspberrypi/linker/kernel.ld: Language not supported

@berkus berkus force-pushed the fix/remove-static-ub branch from a21eda6 to 82c98b9 Compare January 30, 2025 22:41
@berkus berkus force-pushed the fix/remove-static-ub branch 2 times, most recently from 36eb7ed to 3fe6739 Compare April 13, 2025 22:27
@berkus berkus force-pushed the fix/remove-static-ub branch 4 times, most recently from c71f2ce to fc7817e Compare September 14, 2025 15:56
@berkus berkus requested a review from Copilot September 14, 2025 15:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 21 out of 30 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread machine/src/arch/aarch64/cpu/boot.rs
Comment thread machine/src/arch/aarch64/cpu/boot.s
@berkus berkus force-pushed the fix/remove-static-ub branch from 32655d3 to d8560b0 Compare September 14, 2025 18:35
@berkus berkus force-pushed the fix/remove-static-ub branch from d8560b0 to eab7859 Compare September 14, 2025 18:36
@cocogitto-bot
Copy link
Copy Markdown

cocogitto-bot Bot commented Sep 14, 2025

✔️ 413f1d3...eab7859 - Conventional commits check succeeded.

@berkus berkus merged commit 440bc9e into develop Sep 14, 2025
12 checks passed
@berkus berkus deleted the fix/remove-static-ub branch September 14, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean UB in BSS static initalization

2 participants