Implement InitializePersistenceIdInterface #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Izewski <[email protected]>
|
Hi @gsteel, any chance you'll find time to review this PR? |
gsteel
approved these changes
Jun 29, 2024
|
|
||
| public function initializeId(SessionInterface $session): SessionInterface | ||
| { | ||
| if ($session->getId() === '' || $session->isRegenerated()) { |
There was a problem hiding this comment.
Ideally, we would assert the $session instance implements SessionIdentifierAwareInterface, but, we should probably get mezzio-session v2 out the door and make that method part of SessionInterface. See mezzio/mezzio-session#59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing an InitilalizePersistenceIdInterface implementation will enable the ability to access sessionId before it's transmitted in a cookie to the client by a SessionMiddleware.