Skip to content

Conversation

AshishViradiya153
Copy link
Contributor

@AshishViradiya153 AshishViradiya153 commented Jul 16, 2025

Summary by CodeRabbit

  • New Features

    • Added a "Display Settings" section in the dataroom settings, allowing users to toggle the visibility of the "Last updated" information in the dataroom banner.
  • Bug Fixes

    • The "Last updated" timestamp in the dataroom banner now conditionally displays based on user settings.
  • Chores

    • Improved consistency of UI component imports and updated database schema to support the new display setting.

@AshishViradiya153 AshishViradiya153 requested a review from mfts as a code owner July 16, 2025 21:52
Copy link

vercel bot commented Jul 16, 2025

@AshishViradiya153 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jul 16, 2025

Walkthrough

A new boolean field, showLastUpdated, was added to the dataroom model, database schema, and API. The dataroom settings page now includes a toggle to control the visibility of the "Last updated" timestamp in the dataroom banner, with backend and frontend logic updated to support this configurable display setting.

Changes

File(s) Change Summary
prisma/schema/dataroom.prisma, prisma/migrations/.../migration.sql Added showLastUpdated boolean field (default: true) to the Dataroom model and schema.
lib/types.ts Added showLastUpdated: boolean to the nested dataroom object in LinkWithDataroom interface.
lib/api/links/link-data.ts Included showLastUpdated in dataroom fields fetched in fetchDataroomLinkData.
pages/api/teams/[teamId]/datarooms/[id]/index.ts PATCH handler now accepts and updates the showLastUpdated field for datarooms.
components/view/dataroom/nav-dataroom.tsx Conditionally renders "Last updated" timestamp based on dataroom.showLastUpdated.
pages/datarooms/[id]/settings/index.tsx Added display settings section with toggle to update showLastUpdated via PATCH API.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SettingsPage
    participant API
    participant Database

    User->>SettingsPage: Toggle "Show Last Updated"
    SettingsPage->>API: PATCH /datarooms/:id { showLastUpdated }
    API->>Database: Update Dataroom.showLastUpdated
    Database-->>API: Success/Failure
    API-->>SettingsPage: Response
    SettingsPage->>User: Show toast, update toggle state
Loading
sequenceDiagram
    participant User
    participant DataroomNav
    participant API
    participant Database

    User->>DataroomNav: Visit dataroom page
    DataroomNav->>API: Fetch dataroom data (includes showLastUpdated)
    API->>Database: Query Dataroom (with showLastUpdated)
    Database-->>API: Dataroom data
    API-->>DataroomNav: Dataroom data
    alt showLastUpdated == true
        DataroomNav->>User: Render "Last updated" timestamp
    else showLastUpdated == false
        DataroomNav->>User: Hide "Last updated" timestamp
    end
Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-16T21_54_59_630Z-debug-0.log


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6a1a16 and 67cf84c.

📒 Files selected for processing (7)
  • components/view/dataroom/nav-dataroom.tsx (2 hunks)
  • lib/api/links/link-data.ts (1 hunks)
  • lib/types.ts (1 hunks)
  • pages/api/teams/[teamId]/datarooms/[id]/index.ts (2 hunks)
  • pages/datarooms/[id]/settings/index.tsx (4 hunks)
  • prisma/migrations/20250716212601_add_show_last_updated_to_dataroom/migration.sql (1 hunks)
  • prisma/schema/dataroom.prisma (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
components/view/dataroom/nav-dataroom.tsx (1)
lib/utils.ts (1)
  • formatDate (281-292)
🔇 Additional comments (11)
prisma/migrations/20250716212601_add_show_last_updated_to_dataroom/migration.sql (1)

1-2: LGTM! Clean and well-structured migration.

The migration correctly adds the showLastUpdated boolean column with appropriate constraints and default value. The DEFAULT true ensures backward compatibility for existing datarooms.

lib/types.ts (1)

130-130: LGTM! Type definition is consistent and correct.

The showLastUpdated: boolean field is correctly added to the LinkWithDataroom interface, matching the database schema and maintaining type safety.

prisma/schema/dataroom.prisma (1)

30-30: LGTM! Schema definition is well-positioned and correct.

The showLastUpdated field is appropriately placed under notification settings with the correct Boolean type and default value, maintaining consistency with the overall schema structure.

lib/api/links/link-data.ts (1)

113-113: LGTM! Query modification is correct and well-positioned.

The showLastUpdated field is appropriately added to the Prisma select query, ensuring the data is available for the frontend to control timestamp visibility.

pages/api/teams/[teamId]/datarooms/[id]/index.ts (2)

103-109: LGTM! Request body extraction follows established patterns.

The showLastUpdated field is correctly extracted from the request body with proper TypeScript typing, maintaining consistency with other optional fields.


136-136: LGTM! Update logic is consistent and safe.

The conditional update logic for showLastUpdated follows the same pattern as enableChangeNotifications, ensuring only boolean values are processed and maintaining data integrity.

components/view/dataroom/nav-dataroom.tsx (2)

3-3: Import reorganization looks clean and appropriate.

The import statement changes improve consistency by grouping UI components together and using absolute paths. The functional changes don't affect the component's behavior.

Also applies to: 11-12, 16-16


218-225: Conditional rendering implementation is correct and follows best practices.

The implementation properly uses the nullish coalescing operator to default to true when showLastUpdated is undefined, ensuring backward compatibility. The conditional wrapper maintains the existing time element structure and formatting.

pages/datarooms/[id]/settings/index.tsx (3)

28-29: Import additions are appropriate for the new functionality.

The added imports for Label and Switch components are correctly used in the new Display Settings section.


43-69: Solid API integration with proper error handling.

The handler function implements comprehensive error handling:

  • Proper try-catch structure
  • Response status checking
  • Appropriate SWR cache mutations for both dataroom list and specific dataroom
  • Clear user feedback with toast notifications

The implementation follows the existing pattern used elsewhere in the file for similar API operations.


122-145: Well-structured UI implementation with consistent default behavior.

The Display Settings card provides a clean, accessible interface:

  • Proper labeling and description for the toggle
  • Consistent use of dataroom.showLastUpdated ?? true matching the nav component
  • Appropriate use of Switch component with proper event handling

The UI follows the established design patterns used throughout the settings page.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant